Fix: Add test to assert unique() behaviour #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
=========================================
Coverage 58.40% 58.40%
Complexity 2044 2044
=========================================
Files 315 315
Lines 5104 5104
=========================================
Hits 2981 2981
Misses 2123 2123 Continue to review full report at Codecov.
|
1 task
Nyholm
approved these changes
Dec 26, 2020
bram-pkg
reviewed
Dec 26, 2020
| $generator->addProvider(new class(...$words) { | ||
| private $words; | ||
|
|
||
| public function __construct(string ...$words) |
There was a problem hiding this comment.
Why the array deconstruction and not just pass the word array?
There was a problem hiding this comment.
@bramceulemans
Because when passing an array, it would be necessary to write more code to ensure that every element of the array is a string:
/**
* @param array<int, string> $words
*/
public function __construct(array $words)
{
$this->words = array_values(array_map(static function (string $word): string {
return $word;
}, $words));
}or
/**
* @param array<int, string> $words
*
* @throws \InvalidArgumentException
*/
public function __construct(array $words)
{
$notString = array_filter(static function ($word): bool {
return !is_string($word);
}, $words);
if ([] !== $notString) {
throw new \InvalidArgumentException('Every word needs to be a string');
}
$this->words = array_values($words);
}Using variadics here allows me not to write this code.
|
Thank you, @Nyholm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Generator::unique()Related to #155.
πββοΈ As a user of
fakerphp/faker, I would like to continue to be able to useto generate a unique word.
I don't care if it internally uses extensions or providers, but I would like to continue using this behaviour. The tests added here ensure that this is the case.